Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@lexical/devtools] Feature: Added full Safari support #6105

Merged
merged 1 commit into from
May 23, 2024
Merged

[@lexical/devtools] Feature: Added full Safari support #6105

merged 1 commit into from
May 23, 2024

Conversation

StyleT
Copy link
Contributor

@StyleT StyleT commented May 14, 2024 •
edited
Loading

Description

This adds support of the Safari browser for Lexical DevTools browser extension. Build/publish pipeline will follow.

Closes: #5675 (partially)

Test plan

Screen.Recording.2024-05-14.at.3.12.20.PM.mov

More badges!!

Screenshot 2024-05-14 at 6 39 30 PM

@vercel Vercel
Copy link

vercel bot commented May 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 11:25pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 11:25pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 14, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 23.93 KB (0%) 479 ms (0%) 316 ms (-22.69% 🔽) 794 ms
packages/lexical-rich-text/dist/LexicalRichText.js 34.59 KB (0%) 692 ms (0%) 816 ms (-21.11% 🔽) 1.6 s
packages/lexical-plain-text/dist/LexicalPlainText.js 34.59 KB (0%) 692 ms (0%) 923 ms (+2.38% 🔺) 1.7 s

@StyleT StyleT force-pushed the feature/devtools_safari_support branch from 1ab6dd7 to 0680f6e Compare May 14, 2024 22:38
@StyleT StyleT marked this pull request as ready for review May 14, 2024 22:54
@StyleT StyleT added contribution-week Issues that are good to be picked up for the contribution week extended-tests Run extended e2e tests on a PR labels May 14, 2024
@StyleT StyleT force-pushed the feature/devtools_safari_support branch from 0680f6e to b955ca1 Compare May 16, 2024 23:02
Sahejkm
Sahejkm previously approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@Sahejkm Sahejkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there is integerity test failing due to pretty format, need to update before merge

@StyleT StyleT force-pushed the feature/devtools_safari_support branch 2 times, most recently from 8503be1 to 4d4ed1b Compare May 23, 2024 21:53
@StyleT StyleT force-pushed the feature/devtools_safari_support branch from 4d4ed1b to c8f471b Compare May 23, 2024 21:55
@StyleT StyleT requested a review from Sahejkm May 23, 2024 21:55
Sahejkm
Sahejkm previously approved these changes May 23, 2024
View reviewed changes
@StyleT StyleT force-pushed the feature/devtools_safari_support branch from c8f471b to b8a2e8a Compare May 23, 2024 23:24
@StyleT
Copy link
Contributor Author

StyleT commented May 23, 2024

@Sahejkm hey, thanks for previous stamp! Found another versioning issues so I updated the PR

@StyleT StyleT requested a review from Sahejkm May 23, 2024 23:25
@StyleT StyleT added this pull request to the merge queue May 23, 2024
Merged via the queue into main with commit b8573ee May 23, 2024
38 checks passed
This was referenced Jun 26, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sahejkm Sahejkm Sahejkm approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. contribution-week Issues that are good to be picked up for the contribution week extended-tests Run extended e2e tests on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StyleT @Sahejkm @facebook-github-bot